Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve description of client.app_type attribute #325

Merged
merged 1 commit into from
Sep 19, 2022

Conversation

sergiught
Copy link
Contributor

@sergiught sergiught commented Sep 17, 2022

🔧 Changes

Fixes #313 by improving the description of the app_type to include potential values in the docs.

📚 References

🔬 Testing

📝 Checklist

  • All new/changed/fixed functionality is covered by tests (or N/A)
  • I have added documentation for all new/changed functionality (or N/A)

@sergiught sergiught self-assigned this Sep 17, 2022
@sergiught sergiught mentioned this pull request Sep 17, 2022
6 tasks
@sergiught sergiught marked this pull request as ready for review September 17, 2022 12:55
@sergiught sergiught requested a review from a team as a code owner September 17, 2022 12:55
@codecov-commenter
Copy link

Codecov Report

Base: 85.85% // Head: 85.86% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (6b4a1ea) compared to base (4d872f0).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #325   +/-   ##
=======================================
  Coverage   85.85%   85.86%           
=======================================
  Files          39       39           
  Lines        8287     8291    +4     
=======================================
+ Hits         7115     7119    +4     
  Misses        919      919           
  Partials      253      253           
Impacted Files Coverage Δ
internal/provider/resource_auth0_client.go 94.99% <100.00%> (+0.01%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@sergiught sergiught merged commit fda16cc into main Sep 19, 2022
@sergiught sergiught deleted the patch/docs-client-app-type branch September 19, 2022 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing Documentation for clients
3 participants